Thor iOS Application Code Review

Project Overview

The client has some code developed by a third party contributor that they haven't looked at for a while. They'd like to figure out how much of it is usable and which parts will make their developers' heads explode in frustration. The objective of the project is to do a code review of an existing client's iOS and Android Code. We will check many aspects of the code, but not the functionality itself. If you find a defect please log it but that's not the main focus. The focus is code quality. What about this code annoys you? What's done well? Assess it all!

Challenge Overview

In this challenge we are looking to do a high level code review for the iOS application.
 

Technology Stack

• iOS
• Xcode
• Swift

Individual Requirements

• Do a high level code review of the application. You are not required to run the code.
• You need to the check the following points:
  • Code quality: comments, identation, spaces, etc
  • Best practices
    • https://google.github.io/swift/
    • https://developer.apple.com/documentation/swift/swift_standard_library
    • https://swift.org/documentation/api-design-guidelines/
  • Storyboard design and usability
  • Assets usage and compatibility with all iPhone devices
  • Overall Improvements

• The judging will be similar to a Bug hunt
• The user with the most valid code reviews will win
• Points:
  • Code quality - 1 pts
  • Best practices - 2 pts
  • Storyboard design and usability - 1 pt
  • Assets usage and Compatibility with all iPhone devices - 1 pt
  • Overall Improvements - 1 pt

Final Submission Guidelines

• Document will all the code reviews